Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off @typescript-eslint/ban-ts-comment #885

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 10, 2024

Issue

The equivalent is not available in biome which we're planing to move to in #872. It's being worked on in biomejs/biome#713

In codemod, we've only used ts comments when reusing code from jscodeshift, or when there are type issues in implementation which are tested with unit tests.

Description

Turn off @typescript-eslint/ban-ts-comment

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner July 10, 2024 19:55
Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: 80d082c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr trivikr merged commit 9ce31c8 into main Jul 10, 2024
6 checks passed
@trivikr trivikr deleted the disable-ban-ts-comment branch July 10, 2024 20:31
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant