Add nongeneric batchwrite to dynamodbcontext #2506
Conversation
…to add-nongeneric-batchwrite-to-dynamodbcontext
…to add-nongeneric-batchwrite-to-dynamodbcontext
ashishdhingra
added
pr/needs-review
…to add-nongeneric-batchwrite-to-dynamodbcontext
| @@ -200,6 +200,23 @@ internal BatchWrite(DynamoDBContext context, DynamoDBFlatConfig config) | |||
| DocumentBatch = table.CreateBatchWrite(); | |||
| } | |||
|
|
|||
| internal BatchWrite(DynamoDBContext context, Type valuesType, DynamoDBFlatConfig config) | |||
| : base(context, config) | |||
| { | |||
There was a problem hiding this comment.
Since the other constructor contains almost the same code, can you update it to call this one? maybe something like this
internal BatchWrite(DynamoDBContext context, DynamoDBFlatConfig config)
: this(context, typeof(T), config)
{
}
| @@ -226,6 +226,30 @@ public BatchWrite<T> CreateBatchWrite<T>(DynamoDBOperationConfig operationConfig | |||
| return new BatchWrite<T>(this, config); | |||
| } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
Can you update the comments on BatchWrite<object> methods to include details about the object typeparam and how it is different from the generic version.
| @@ -162,6 +162,15 @@ public partial interface IDynamoDBContext : IDisposable | |||
| /// <param name="operationConfig">Config object which can be used to override that table used.</param> | |||
| /// <returns>Empty strongly-typed BatchWrite object</returns> | |||
| BatchWrite<T> CreateBatchWrite<T>(DynamoDBOperationConfig operationConfig = null); | |||
|
|
|||
There was a problem hiding this comment.
Can you add this method to BCL35 too, similar to the methods at lines 146 & 155
…to add-nongeneric-batchwrite-to-dynamodbcontext
…ments code, and add BCL35 support.
|
@muhammad-othman -- I believe I have addressed your PR comments. Let me know if there is any additional cleanup needed. Thanks! |
|
@ericjpeters Changes look good. I'll send the PR through our full dry run build and assuming that doesn't have any issues I'll approve it. |
|
PR is queued up to go out with next non-service update release. Those types of releases usually happen about once every other week. |
|
The PR was rebased, merged and released as part of version 3.7.104 of the DynamoDB package. Thanks for the PR! |
As an expansion to #2503, this provide non-generic put's in batch.
Description
Allows for a batch put without needing a strongly typed T.
Motivation and Context
See #2503 for more detail, but makes for easy integration with EF's for batch deleting where the items are archived into DynamoDB.
Testing
Sorry, I still can't seem to get the tests to build. I have tested locally by integrating into an EF application.
Types of changes
Checklist
License