Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CopyObjectRequestMarshaller to throw ArgumentException for missing properties #3234

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

muhammad-othman
Copy link
Member

@muhammad-othman muhammad-othman commented Mar 23, 2024

Description

CopyObject request is throwing unmeaningful exception when one of its required parameters is missing (except DestinationBucket which is handled correctly).

Motivation and Context

A customer raised this issue #3193 when using CopyObjectAsync.

Testing

  • Tested the same code that was included in the issue and added unit tests to cover all cases of missing properties.
  • Did a full dry run DRY_RUN-d3c91a42-e7d1-4c82-ba55-7a4cd64112e0.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@muhammad-othman muhammad-othman force-pushed the p1-bug-copyobject-unclear-exception branch from f923bba to 1a41d36 Compare March 25, 2024 12:37
@muhammad-othman muhammad-othman merged commit 5b29a69 into main-staging Mar 29, 2024
2 checks passed
@muhammad-othman muhammad-othman deleted the p1-bug-copyobject-unclear-exception branch March 29, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants