Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue 8 hanging on CDATA. #3246

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

boblodgett
Copy link
Contributor

Description

This PR fixes DOTNET-7357 issue 8. Issue 8 XML Unmarshaller hangs forever for Test: SimpleScalarPropertiesWithXmlPreambleResponse

  • (Review manual changes) commit 377f602 - Fixes for issue 8 hanging on CDATA.
  • No generated changes for this manual change

MERGE into protocol-tests feature branch only

Builds on prior PR: #3242
Merge order: 5
Ticket: DOTNET-7357

Motivation and Context

Testing

N/A - the test cases are the protocol tests. A final dry-run will be done on the protocol-tests feature branch once everything is merged into the feature branch.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@boblodgett boblodgett requested a review from peterrsongg April 3, 2024 16:47
Base automatically changed from protocol-tests-1.0.96.0 to protocol-tests April 3, 2024 18:12
@boblodgett boblodgett merged commit 6ef39a2 into protocol-tests Apr 3, 2024
2 checks passed
@boblodgett boblodgett deleted the protocol-tests-issue8 branch April 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants