Protocol tests issue 27 #3260
Merged
Protocol tests issue 27 #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrsongg
commented
Apr 4, 2024
| @@ -352,7 +352,7 @@ internal static void WriteJson(DynamoDBEntry entry, JsonWriter writer, DynamoDBE | |||
| var ddbNull = entry as DynamoDBNull; | |||
| if (ddbNull != null) | |||
| { | |||
| writer.Write(null); | |||
| writer.Write((string)null); | |||
There was a problem hiding this comment.
this was just to fix a build problem for the nullable value types in collections. Bo and I talked about making this change.
There was a problem hiding this comment.
Yes, it was one I missed from this commit which we PRed: b19a010
normj
approved these changes
Apr 4, 2024
boblodgett
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes DOTNET-7357 issue 27.
Rest-XML Protocol not flattening maps correctlyMERGE into
protocol-testsfeature branch onlyBuilds on prior PR: #3256
Merge order: 108 (I'm going to start mine from 100 and increment to keep separate from Bo's)
Ticket: DOTNET-7357
Motivation and Context
Testing
N/A - the test cases are the protocol tests. A final dry-run will be done on the
protocol-testsfeature branch once everything is merged into the feature branch.Screenshots (if appropriate)
Types of changes
Checklist
License