Protocol tests issue 31 #3265
Merged
Protocol tests issue 31 #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For real services, there are only whitespace changes. Only the test services have real changes |
peterrsongg
commented
Apr 5, 2024
| xmlWriter.WriteStartElement("flattenedListWithMemberNamespace"); | ||
| foreach (var publicRequestFlattenedListWithMemberNamespaceValue in publicRequestFlattenedListWithMemberNamespace) | ||
| { | ||
| xmlWriter.WriteStartElement("member"); | ||
| xmlWriter.WriteStartElement("member", "https://xml-member.example.com"); |
There was a problem hiding this comment.
Here is an example of the change that this introduces.
peterrsongg
commented
Apr 5, 2024
| { | ||
| xmlWriter.WriteStartElement("entry"); | ||
| xmlWriter.WriteElementString("K", kvp.Key); | ||
| xmlWriter.WriteElementString("V", kvp.Value); | ||
| xmlWriter.WriteElementString("K","https://the-key.example.com",kvp.Key); |
There was a problem hiding this comment.
another example here
peterrsongg
commented
Apr 5, 2024
| { | ||
| xmlWriter.WriteStartElement("values"); | ||
| { | ||
| xmlWriter.WriteStartElement("values", "http://qux.com"); |
This was referenced Apr 5, 2024
boblodgett
reviewed
Apr 5, 2024
Comment on lines
191
to
224
| /// <summary> | ||
| /// Gets the map's key node's xmlnamespace. | ||
| /// </summary> | ||
| public string KeyShapeXmlNamespace | ||
| { | ||
| /* | ||
| "type": "map", | ||
| "key": { | ||
| "shape": "String", | ||
| "locationName": "K", | ||
| "xmlNamespace": "https://the-key.example.com" | ||
| }, | ||
| */ | ||
| get | ||
| { | ||
| var keyNode = this.data[KeyKey]; | ||
| if (keyNode == null || keyNode[ServiceModel.XmlNamespaceKey] == null) | ||
| return ""; | ||
| return (string)keyNode[ServiceModel.XmlNamespaceKey]; | ||
| } | ||
| } | ||
| /// <summary> | ||
| /// Gets the map's value node's xmlnamespace | ||
| /// </summary> | ||
| public string ValueShapeXmlNamespace | ||
| { | ||
| get | ||
| { | ||
| var valueNode = this.data[ValueKey]; | ||
| if (valueNode == null || valueNode[ServiceModel.XmlNamespaceKey] == null) | ||
| return ""; | ||
| return (string)valueNode[ServiceModel.XmlNamespaceKey]; | ||
| } | ||
| } |
There was a problem hiding this comment.
These don't check for IsMap. Should the base methods be modified instead with specific instructions for IsMap type shapes/members"?
There was a problem hiding this comment.
hmm I think that might be better actually, let me try to make that change and see if it works
There was a problem hiding this comment.
Spoke to Bo offline and we agreed that since this is only valid on a shape, it shouldn't be on the base class. Instead I just added a check for ISMap
boblodgett
approved these changes
Apr 5, 2024
jnunn-aws
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes DOTNET-7357 issue 31.
Issue 31 Rest-XML Requests, not setting the xmlNamespace on individual member valuesnote: I commented where the real changes are for an easier review
MERGE into
protocol-testsfeature branch onlyBuilds on prior PR: #3261
Merge order: 110 (I'm going to start mine from 100 and increment to keep separate from Bo's)
Ticket: DOTNET-7357
Motivation and Context
Testing
N/A - the test cases are the protocol tests. A final dry-run will be done on the
protocol-testsfeature branch once everything is merged into the feature branch.Screenshots (if appropriate)
Types of changes
Checklist
License