-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to mock document model operations in DynamoDB #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96malhar
force-pushed
the
kmalhar/mock-document-model
branch
from
August 19, 2024 01:14
4ae7483
to
5f7d866
Compare
philasmar
approved these changes
Aug 20, 2024
sdk/src/Services/DynamoDBv2/Custom/DocumentModel/DocumentTransactWrite.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DocumentModel/DocumentTransactWrite.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DocumentModel/DocumentTransactWrite.cs
Outdated
Show resolved
Hide resolved
philasmar
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hit Approve by mistake
philasmar
approved these changes
Aug 21, 2024
normj
approved these changes
Aug 21, 2024
…hWrite operations
…nsactGet operations
…ransactWrite operations
96malhar
force-pushed
the
kmalhar/mock-document-model
branch
from
August 21, 2024 22:09
a26f8fd
to
c47c3c2
Compare
96malhar
added a commit
that referenced
this pull request
Aug 21, 2024
* Add the ability to mock DocumentBatchGet and MultiTableDocumentBatchGet operations * Add the ability to mock DocumentBatchWrite and MultiTableDocumentBatchWrite operations * Add the ability to mock DocumentTransactGet and MultiTableDocumentTransactGet operations * Add the ability to mock DocumentTransactWrite and MultiTableDocumentTransactWrite operations * Add the ability to mock Search operations in Document model * Add the ability to mock Table operations in Document model * Fix typos
philasmar
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Add the ability to mock DocumentBatchGet and MultiTableDocumentBatchGet operations * Add the ability to mock DocumentBatchWrite and MultiTableDocumentBatchWrite operations * Add the ability to mock DocumentTransactGet and MultiTableDocumentTransactGet operations * Add the ability to mock DocumentTransactWrite and MultiTableDocumentTransactWrite operations * Add the ability to mock Search operations in Document model * Add the ability to mock Table operations in Document model * Fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to mock document model operations in DynamoDB:
ITable
interface.ISearch
interface.IDocumentTransactWrite
andIMultiTableDocumentTransactWrite
interfaces.IDocumentTransactGet
andIMultiTableDocumentTransactGet
interfaces.IDocumentBatchWrite
andIMultiTableDocumentBatchWrite
interfaces.IDocumentBatchGet
andIMultiTableDocumentBatchGet
interfaces.I have added new unit tests to showcase how a user will mock these interfaces.
Motivation and Context
DOTNET-7677
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License