[SRA] Update service clients to remove usage of fallback credentials factory #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-othman
force-pushed
the
muhamoth/DOTNET-7538-sra-remove-fallbackcredentialsfactory-from-serviceclients
branch
from
ac78a48 to
a7af869
Compare
dscpinheiro
approved these changes
Nov 7, 2024
normj
approved these changes
Nov 8, 2024
Co-authored-by: Daniel Pinheiro <[email protected]>
dscpinheiro
deleted the
muhamoth/DOTNET-7538-sra-remove-fallbackcredentialsfactory-from-serviceclients
branch
muhammad-othman
added a commit
that referenced
this pull request
Nov 25, 2024
…factory (#3546) Update service clients to remove usage of fallback credentials factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FallbackCredentialFactoryin service client constructors (limited toAutoScalingservice for now to avoid huge merge conflicts later).AmazonServiceClient.Credentialsto beDefaultAWSCredentials.IdentityResolverConfigurationproperty to the client config.ClientConfig.AWSTokenProviderproperty as obsolete.TODO: Remove the creation of the Signer property (will work on this part while updating the signer handler).
Motivation and Context
DOTNET-7538