[SRA] Add identity resolver for bearer authentication scheme #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscpinheiro
force-pushed
the
dspin/DOTNET-7652-sso-auth-scheme
branch
from
29eda94 to
a7f126e
Compare
normj
reviewed
Dec 4, 2024
extensions/src/Smithy.Identity.Abstractions/Identity/IIdentityResolver.cs
Outdated
Show resolved
Hide resolved
normj
requested changes
Dec 4, 2024
...ore/Amazon.Runtime/Credentials/Internal/IdentityResolvers/DefaultAWSTokenIdentityResolver.cs
Outdated
Show resolved
Hide resolved
.../Core/Amazon.Runtime/Credentials/Internal/IdentityResolvers/IdentityResolverConfiguration.cs
Show resolved
Hide resolved
normj
reviewed
Dec 6, 2024
...ore/Amazon.Runtime/Credentials/Internal/IdentityResolvers/DefaultAWSTokenIdentityResolver.cs
Outdated
Show resolved
Hide resolved
.../Core/Amazon.Runtime/Credentials/Internal/IdentityResolvers/IdentityResolverConfiguration.cs
Show resolved
Hide resolved
sdk/src/Core/Amazon.Runtime/Pipeline/Handlers/BaseAuthResolverHandler.cs
Show resolved
Hide resolved
* Update signer to accept BaseIdentity instead of ImmutableCredentials * Use ClientException instead of ServiceException in FallbackCredentialsFactory replacement * Update blocking call to use .GetAwaiter().GetResult()
muhammad-othman
approved these changes
Dec 10, 2024
...ore/Amazon.Runtime/Credentials/Internal/IdentityResolvers/DefaultAWSTokenIdentityResolver.cs
Outdated
Show resolved
Hide resolved
sdk/src/Core/Amazon.Runtime/Pipeline/Handlers/BaseAuthResolverHandler.cs
Outdated
Show resolved
Hide resolved
normj
reviewed
Dec 10, 2024
There was a problem hiding this comment.
In the AbstractAWSSigner we need to get rid of the abstract Sign operation that takes in a access and secret key so we are always dealing with the BaseIdentity. I created a PR to this PR that does that work and I'm currently running the dry run. Assuming the dry run is successful and @muhammad-othman approves my PR we can merge that PR into this PR and then I'll approve this PR so we can merge it.
normj
approved these changes
Dec 12, 2024
muhammad-othman
pushed a commit
that referenced
this pull request
Dec 19, 2024
* feat: Add bearer token authentication scheme * refactor: Address PR feedback * refactor: Address PR comments * Update signer to accept BaseIdentity instead of ImmutableCredentials * Use ClientException instead of ServiceException in FallbackCredentialsFactory replacement * Update blocking call to use .GetAwaiter().GetResult() * fix: Update S3Express handler for signer signature change * fix: Update AWSToken to use correct base class * fix: Update comment for blocking call * fix: Add blocking call in pipeline handler * Remove abstract Sign override that uses access and secret key. (#3575) --------- Co-authored-by: Norm Johanson <[email protected]>
muhammad-othman
pushed a commit
that referenced
this pull request
Jan 3, 2025
* feat: Add bearer token authentication scheme * refactor: Address PR feedback * refactor: Address PR comments * Update signer to accept BaseIdentity instead of ImmutableCredentials * Use ClientException instead of ServiceException in FallbackCredentialsFactory replacement * Update blocking call to use .GetAwaiter().GetResult() * fix: Update S3Express handler for signer signature change * fix: Update AWSToken to use correct base class * fix: Update comment for blocking call * fix: Add blocking call in pipeline handler * Remove abstract Sign override that uses access and secret key. (#3575) --------- Co-authored-by: Norm Johanson <[email protected]>
dscpinheiro
added a commit
that referenced
this pull request
Jan 12, 2025
* feat: Add bearer token authentication scheme * refactor: Address PR feedback * refactor: Address PR comments * Update signer to accept BaseIdentity instead of ImmutableCredentials * Use ClientException instead of ServiceException in FallbackCredentialsFactory replacement * Update blocking call to use .GetAwaiter().GetResult() * fix: Update S3Express handler for signer signature change * fix: Update AWSToken to use correct base class * fix: Update comment for blocking call * fix: Add blocking call in pipeline handler * Remove abstract Sign override that uses access and secret key. (#3575) --------- Co-authored-by: Norm Johanson <[email protected]>
dscpinheiro
added a commit
that referenced
this pull request
Jan 29, 2025
* feat: Add bearer token authentication scheme * refactor: Address PR feedback * refactor: Address PR comments * Update signer to accept BaseIdentity instead of ImmutableCredentials * Use ClientException instead of ServiceException in FallbackCredentialsFactory replacement * Update blocking call to use .GetAwaiter().GetResult() * fix: Update S3Express handler for signer signature change * fix: Update AWSToken to use correct base class * fix: Update comment for blocking call * fix: Add blocking call in pipeline handler * Remove abstract Sign override that uses access and secret key. (#3575) --------- Co-authored-by: Norm Johanson <[email protected]>
dscpinheiro
added a commit
that referenced
this pull request
Feb 15, 2025
* feat: Add bearer token authentication scheme * refactor: Address PR feedback * refactor: Address PR comments * Update signer to accept BaseIdentity instead of ImmutableCredentials * Use ClientException instead of ServiceException in FallbackCredentialsFactory replacement * Update blocking call to use .GetAwaiter().GetResult() * fix: Update S3Express handler for signer signature change * fix: Update AWSToken to use correct base class * fix: Update comment for blocking call * fix: Add blocking call in pipeline handler * Remove abstract Sign override that uses access and secret key. (#3575) --------- Co-authored-by: Norm Johanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
IdentityResolverConfigurationto resolve the bearer authentication scheme (i.e. thesmithy.api#httpBearerAuthtrait). I also had to modify other existing components (such as the bearer token signer) since their implementation is different than SigV4 / SigV4A credentials.Motivation and Context
DOTNET-7652Testing
DRY_RUN-53687653-2c3c-4b33-9fa5-1ac8868e497a.nupkgfile - will address that in a separate PR).Types of changes
Checklist
License