[V4] Remove and adjust unused targets NET35 and NET45 from codebase. #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boblodgett
commented
Feb 4, 2025
Comment on lines
+4
to
5
| $dllpath = "..\lib\net472\AWSSDK.Core.dll" | ||
| $sdkassembly = [System.Reflection.Assembly]::LoadFrom($dllpath) |
There was a problem hiding this comment.
@normj do you know why this is here? The script doesn't even use $sdkassembly but I figured you added this long ago for some kind of preloading that is needed from AWSSDK.Core.dll for the script to work. Second I am not certain we even need this script anymore.
dscpinheiro
reviewed
Feb 4, 2025
| @@ -1497,55 +1497,6 @@ private static void RemoveOrphanedServices(string path, IEnumerable<string> code | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
Don't we need to keep this here as long as we're doing syncs from V3? Any new service will have the _bcl35 folder for example.
There was a problem hiding this comment.
We should hold onto this PR until we are ready for GA then and merge it after we do the final sync. Perhaps it was too early to do this cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: The
docgenerator\AWSSDKDocSamplesproject still has a reference to AWSSDK v2 and is using net35. This solution/project does not build or run. Attempted to update to net8 but the project has many build errors and will not compile without fixing the generated sample code. This is a larger effort that will need to be addressed as another task.Motivation and Context
This is a cleanup task to ensure we have removed net45 and net35 targets.
SIM:
DOTNET-7610Testing
DryRun (Succeeded): DRY_RUN-59f922a9-6d50-45c6-8990-e65290ac7b70
Screenshots (if appropriate)
Types of changes
Checklist
License