add CompleteMultipartUploadResponse mapping to TransferUtilityResponse object #4046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new mapping function to convert CompleteMultipartUploadResponse objects to TransferUtilityUploadResponse objects within the AWS .NET SDK's S3 service. This enhancement provides consistency with existing response mapping patterns in the transfer utility.
- Added
MapCompleteMultipartUploadResponsemethod in ResponseMapper.cs to handle the conversion - Added comprehensive unit tests to validate the mapping functionality and null value handling
- Included appropriate dev config for patch-level change tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ResponseMapper.cs | Implements new mapping method from CompleteMultipartUploadResponse to TransferUtilityUploadResponse |
| ResponseMapperTests.cs | Adds unit tests for the new mapping functionality including edge cases |
| 433a9a6d-b8ea-4676-b763-70711e8288e6.json | Dev config file marking this as a patch-level change |
10 tasks
… upload update docs and function namse update comments add tests/update comments remove response from progressargs add missing properties update test Refactor test rearrange test update tests add commented out tests comments comments update comments fix spelling use interlocked read and fix build dev config update comment fix internals
GarrettBeatty
force-pushed
the
gcbeatty/simpleuploadprogresstracking
branch
from
352afda to
a5de17c
Compare
GarrettBeatty
changed the title
GarrettBeatty
force-pushed
the
gcbeatty/tuuploadresponsemulti
branch
from
c9687e7 to
4f32bc1
Compare
GarrettBeatty
force-pushed
the
gcbeatty/simpleuploadprogresstracking
branch
from
3f70b05 to
9bd94c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4045 but for CompleteMultipartUploadResponse
Description
Motivation and Context
Testing
da20a787-17c1-42c6-b5d7-f652737b948f
Screenshots (if appropriate)
Types of changes
Checklist
License