Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix denylisting x-amz-user-agent in SignatureV4 #2882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eduard-sukharev
Copy link

When checking headers for signature inclusion, they are lowercased, thus X-Amz-User-Agent is never skipped from signature, even though it is blacklisted exactly like that.

Description of changes:
X-Amz-User-Agent turned to lowercase in blacklist, as all checks with blacklist are with lowercased headers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

When checking headers for signature inclusion, they are lowercased, thus `X-Amz-User-Agent` is never skipped from signature, even though it is blacklisted exactly like that.
@eduard-sukharev
Copy link
Author

@stobrien89 @yenfryherrerafeliz could you guys have a look at this, please?
and also I don't know why the pipeline fails on some PHP versions, it's pretty much a straightforward fix

@yenfryherrerafeliz yenfryherrerafeliz changed the title Fix blacklisting x-amz-user-agent in SignatureV4 Fix denylisting x-amz-user-agent in SignatureV4 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants