Ignore __type in Union (#2922)

Co-authored-by: Matt Muller <[email protected]>
aws · Oct 4, 2023 · f6d57e7 · f6d57e7
1 parent e0da76e
commit f6d57e7
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 1 deletion.
diff --git a/build_tools/aws-sdk-code-generator/spec/protocols/output/rest-json.json b/build_tools/aws-sdk-code-generator/spec/protocols/output/rest-json.json
@@ -1032,6 +1032,44 @@
           "headers": {},
           "body": "{\"UnionMember\": {\"SomeUnknownMember\": \"un-modeled member\"}}"
         }
+      },
+      {
+        "given": {
+          "output": {
+            "shape": "OutputShape"
+          },
+          "name": "OperationName"
+        },
+        "result": {
+          "UnionMember": {"S":  "string value"}
+        },
+        "resultClass": {
+          "UnionMember": "UnionType::S"
+        },
+        "response": {
+          "status_code": 200,
+          "headers": {},
+          "body": "{\"UnionMember\": {\"__type\": \"UnionType\", \"S\": \"string value\"}}"
+        }
+      },
+      {
+        "given": {
+          "output": {
+            "shape": "OutputShape"
+          },
+          "name": "OperationName"
+        },
+        "result": {
+          "UnionMember": {"Unknown":  {"name": "SomeUnknownMember", "value": "un-modeled member"}}
+        },
+        "resultClass": {
+          "UnionMember": "UnionType::Unknown"
+        },
+        "response": {
+          "status_code": 200,
+          "headers": {},
+          "body": "{\"UnionMember\": {\"SomeUnknownMember\": \"un-modeled member\", \"__type\": \"UnionType\"}}"
+        }
       }
     ]
   }

diff --git a/gems/aws-sdk-core/CHANGELOG.md b/gems/aws-sdk-core/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Issue - Ignore `__type` when deserializing Unions.
+
 3.185.0 (2023-10-02)
 ------------------
 

diff --git a/gems/aws-sdk-core/lib/aws-sdk-core/json/parser.rb b/gems/aws-sdk-core/lib/aws-sdk-core/json/parser.rb
@@ -28,7 +28,7 @@ def structure(ref, values, target = nil)
           member_name, member_ref = shape.member_by_location_name(key)
           if member_ref
             target[member_name] = parse_ref(member_ref, value)
-          elsif shape.union
+          elsif shape.union && key != '__type'
             target[:unknown] = { 'name' => key, 'value' => value }
           end
         end