Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple attributes support for conditional check errors #2917

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

mullermp
Copy link
Contributor

Simple attributes support for conditional check errors. When configured, it will return item data, preventing another get item call. The item data should be simplified if configured to do so. This is a breaking change for existing users however the feature is fairly new.

Will investigate test failures

Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM!

@mullermp mullermp merged commit f4a09d8 into version-3 Sep 26, 2023
27 checks passed
@mullermp mullermp deleted the simple-attributes-conditional-error branch September 26, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants