Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginator definitions for CostExplorer API #3041

Open
wants to merge 2 commits into
base: version-3
Choose a base branch
from

Conversation

thomasklemm
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

@mullermp
Copy link
Contributor

mullermp commented Jun 11, 2024

Thanks for opening a pull request. Unfortunately these need to be merged upstream by the service team. I can inform them of the work you've done and they will prioritize this accordingly.

V1413840028

@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from e166a7c to 0259892 Compare June 18, 2024 08:11
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch 2 times, most recently from 1f588fa to 0ddf23f Compare July 1, 2024 06:55
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from 0ddf23f to c754786 Compare July 6, 2024 05:28
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from c754786 to 6e737a7 Compare July 17, 2024 10:58
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from 6e737a7 to e68c342 Compare August 2, 2024 10:23
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from e68c342 to 3be93b6 Compare August 21, 2024 09:32
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from 3be93b6 to 68b52b7 Compare September 2, 2024 11:41
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from 68b52b7 to 9819bc5 Compare September 12, 2024 10:48
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from 9819bc5 to 9497202 Compare September 23, 2024 06:55
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from 9497202 to f92fd09 Compare October 2, 2024 07:42
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from f92fd09 to 9dfd1d9 Compare October 17, 2024 06:57
- Includes the new paginator definitions for the Cost Explorer API,
  so #next_page?, #next_page and other pagination methods are now
  properly working on the response
@thomasklemm thomasklemm force-pushed the feat/paginator-definitions-for-cost-explorer-api branch from 9dfd1d9 to fc4dff2 Compare October 28, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants