Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix h2 connections to use config values #3214

Merged
merged 6 commits into from
Mar 21, 2025
Merged

Fix h2 connections to use config values #3214

merged 6 commits into from
Mar 21, 2025

Conversation

mullermp
Copy link
Contributor

Actually set the default this time.

alextwoods
alextwoods approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should potentially add a comment to the h2 plugin that calls out that the defaults aren't used and that we need to also update them in the h2 connection class.

@mullermp mullermp changed the title Set enable_alpn default to true Fix h2 connections to use config values Mar 21, 2025
@mullermp mullermp merged commit b15b57a into version-3 Mar 21, 2025
34 checks passed
@mullermp mullermp deleted the alpn-default branch March 21, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextwoods alextwoods alextwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods