Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECRPushImage warning in Azure Devops due to Node10 dependency #566

Open
ganeshranfignum opened this issue Sep 25, 2024 · 15 comments
Open

ECRPushImage warning in Azure Devops due to Node10 dependency #566

ganeshranfignum opened this issue Sep 25, 2024 · 15 comments

Comments

@ganeshranfignum
Copy link

The ECRPushImage Task uses Node10 which is no longer supported . This causes a warning to be displayed on our build process in Azure Devops

##[warning]Task 'Amazon ECR Push' version 1 (ECRPushImage@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

@jbstans
Copy link

jbstans commented Sep 25, 2024

This isn't just limited to ECR - we're getting the same on AWSShellScript:

##[warning]Task 'AWS Shell Script' version 1 (AWSShellScript@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

I suspect the whole toolkit needs a v2 with a node update.

@mhvelplund
Copy link

AWS support ADO seems pretty dead. I wish I was stuck with ADO either :/

@mhvelplund
Copy link

I found out why they don't just bump the Node version. From PR #560:

Supporting node 16 requires bumping azure-pipelines-task-lib. We are currently blocked from doing this because this version bump uses a newer version of shelljs as a dependency, which produces runtime errors for our task. (see PR description in #539 for more details).

@decampo04
Copy link

Just to add, also seeing this on SystemsManagerGetParameter@1 task too:

##[warning]Task 'AWS SSM Get Parameter' version 1 (SystemsManagerGetParameter@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

@seanezell
Copy link

Just to add to the pile, we are seeing this on S3Upload, AWSShellScript.

We are also seeing the same on Terraform and Terraform-outputs. Different extensions, but the same issue.

@JeroenBodeTriple
Copy link

Same issue here for the AWSCLI, AWSShellScript, LambdaDeployFunction and ECRPushImage on our end.
My guess is all the tasks for the aws-toolkit-azure-devops are affected by this.

@symnatbay
Copy link

Seeing the same over in our org. No new information, just leaving this comment to help express the potential impact of this deprecation.

@sameerahmed720
Copy link

Its a on going issue with AWS and Terraform , fixed terraform issue by upgrading its version
But AWSShellScript , AWSCLI issue is consistent even after version upgrade

@isarastov
Copy link

I'm seeing the same for S3Upload@1, SendMessage@1

@tayalnishu
Copy link

tayalnishu commented Nov 5, 2024

+1. Getting the same error for all tasks used from aws-toolkit-azure-devops. Would be good to know the timeline when it is expected to be upgraded.

@ashokm
Copy link

ashokm commented Nov 6, 2024

See jfrog/jfrog-azure-devops-extension#518 for inspiration on addressing the issue.
This seems to have worked for the JFrog marketplace extension, and the warning is no longer appearing.

@rynop
Copy link

rynop commented Nov 6, 2024

Anyone have an official Microsoft doc that states when they are pulling the plug on node v10?

I opened an AWS support ticket and I can tell you AWS is aware of this.

@saurabhajmera
Copy link

I like to acknowledge that we are aware of this problem. In our past attempts to address this, we got blocked by a shelljs related JS bundler issue which prevented us from updating azure-pipelines-task-lib. We are looking into this again and will post an update once we have more information.

@adurangalvis
Copy link

I like to acknowledge that we are aware of this problem. In our past attempts to address this, we got blocked by a shelljs related JS bundler issue which prevented us from updating azure-pipelines-task-lib. We are looking into this again and will post an update once we have more information.

Is there a timeline when this is planned to be resolved?

@saurabhajmera
Copy link

Is there a timeline when this is planned to be resolved?

Not yet, but we will share more information once we have an update. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests