vscode: add "source" field to executeCommand metric #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a vscode command is executed it can be executed from different places. The 'source' field will help to identify what caused the command to execute. Signed-off-by: nkomonen <[email protected]>
nkomonen-amazon
force-pushed
the
executeCommandSource
branch
from
9d4996b to
ed5b50b
Compare
justinmk3
approved these changes
Nov 1, 2023
dhruvigajjar
reviewed
Nov 2, 2023
| @@ -35,6 +35,7 @@ | |||
| "passive": true, | |||
| "metadata": [ | |||
| { "type": "command" }, | |||
| { "type": "source" }, | |||
| { "type": "debounceCount" }, | |||
There was a problem hiding this comment.
are we updating all existing vscode_executeCommand emissions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a vscode command is executed it can be executed from different places. The 'source' field will help to identify what caused the command to execute.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.