Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre validation project details #695

Merged
merged 16 commits into from
Feb 16, 2024

Conversation

damntrecky
Copy link
Contributor

Problem

We need to add telemetry to log general project details earlier on in the funnel.

  1. Requirements -> https://issues.amazon.com/issues/EGCP-43

We are altering how we validate projects over a milestone increase "acceptance rate", but right now we are initiating validation as optional

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@damntrecky damntrecky changed the title Nardeck/pre validation project details pre validation project details Feb 15, 2024
@damntrecky damntrecky marked this pull request as ready for review February 15, 2024 21:49
@damntrecky damntrecky requested a review from a team as a code owner February 15, 2024 21:49
"type": "codeTransformSessionId",
"required": true
},
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result can be a failure if the project is not valid for transform in which case the optional reason can be filled with more details as well.

@dhruvigajjar dhruvigajjar merged commit b6e75ac into aws:main Feb 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants