-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre validation project details #695
Merged
dhruvigajjar
merged 16 commits into
aws:main
from
damntrecky:nardeck/preValidationProjectDetails
Feb 16, 2024
Merged
pre validation project details #695
dhruvigajjar
merged 16 commits into
aws:main
from
damntrecky:nardeck/preValidationProjectDetails
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damntrecky
changed the title
Nardeck/pre validation project details
pre validation project details
Feb 15, 2024
dhasani23
approved these changes
Feb 15, 2024
damntrecky
commented
Feb 15, 2024
"type": "codeTransformSessionId", | ||
"required": true | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result can be a failure if the project is not valid for transform in which case the optional reason can be filled with more details as well.
dhruvigajjar
approved these changes
Feb 15, 2024
dhruvigajjar
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to add telemetry to log general project details earlier on in the funnel.
We are altering how we validate projects over a milestone increase "acceptance rate", but right now we are initiating validation as optional
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.