telemetry(CodeTransform): enhance metrics #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhasani23
commented
Feb 16, 2024
| @@ -1088,8 +1090,9 @@ | |||
| "type": "string", | |||
| "description": "Type of maven command", | |||
| "allowedValues": [ | |||
| "mvn", | |||
| "mvnw.cmd", | |||
There was a problem hiding this comment.
For Windows machines
dhruvigajjar
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Want telemetry to see how often users select "Other" in Java version selection drop down. Want telemetry to see how often users are shown the input prompt to enter their JAVA_HOME (happens when project JDK differs from Maven JDK). Needed to revise the
CodeTransformMavenBuildCommandfield to be more accurate.Solution
Implement the above.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.