Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeTransform_localBuildProject metric #4748

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

tincheng
Copy link
Contributor

@tincheng tincheng commented Jul 31, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

When emitting codeTransform_localBuildProject metric, do not treat the result as Failed if maven copy-dependencies failed as local build (maven install) can still succeed. Include a message in reason field if copy failed.

Also add an additional log for capturing JDK version.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tincheng tincheng requested a review from a team as a code owner July 31, 2024 01:07
@tincheng tincheng requested a review from dhasani23 August 2, 2024 00:54
@tincheng tincheng merged commit 400987d into aws:main Aug 2, 2024
11 of 12 checks passed
@tincheng tincheng deleted the fix_localBuildProject_metric branch August 2, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants