fix(amazonqFeatureDev): add retry step after user change workspace folder #5413 #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyyhuang
approved these changes
Aug 2, 2024
rli
approved these changes
Aug 2, 2024
| followUp = listOf( | ||
| FollowUp( | ||
| pillText = message("amazonqFeatureDev.follow_up.retry"), | ||
| type = FollowUpTypes.RETRY, |
There was a problem hiding this comment.
would it make more sense for the retry to be automatic after they select a new folder?
There was a problem hiding this comment.
We're allowing user change the previous prompt based on the new folder selection. The assumption is that the user could want change the prompt after change the selected folder so that's why we show the retry button but keep the input open for other input.
zixlin7
pushed a commit
to zixlin7/aws-toolkit-jetbrains
that referenced
this pull request
Aug 8, 2024
…lder #5413 (aws#4758) * fix(amazonqFeatureDev): add retry step after user change workspace folder * chore(amazonqFeatureDev): include changelog * refactor(amazonqFeatureDev): remove lock not used * refactor(amazonqFeatureDev): add revised string for input placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem
When selected folder/workspace size its too large, we prompt to select a smaller one. However, after selected, user describe that doesn't retry again forcing to rewrite the prompt again.
For reference, VS Code PR: https://github.com/aws/aws-toolkit-vscode/pull/5413/files
Solution
This PR adds a retry button option after it changes the workspace folder and update the placeholder, allowing user choose rewrite the prompt or retry the previous one.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.