Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amazonq): warn user if absolute path found in pom.xml #4762

Merged
merged 20 commits into from
Aug 7, 2024
Merged

feat(amazonq): warn user if absolute path found in pom.xml #4762

merged 20 commits into from
Aug 7, 2024

Conversation

dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Aug 3, 2024 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

When absolute paths are present in the pom.xml, the backend build may fail, so warn users.

image

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners August 3, 2024 01:15
@dhasani23 dhasani23 changed the title fix(amazonq): warn user if absolute path found in pom.xml feat(amazonq): warn user if absolute path found in pom.xml Aug 3, 2024
@tincheng
Copy link
Contributor

tincheng commented Aug 6, 2024

Non-blocking, but I think the message ...Any errors will show up in the build log. can be clearer. It should point to the failure build log that QCT will provide back, as right now it's easy to mistaken the "build log" to be idea.log.

@dhasani23 dhasani23 enabled auto-merge (squash) August 7, 2024 21:48
@dhasani23
Copy link
Contributor Author

/retryBuilds

@dhasani23 dhasani23 merged commit 4a61ea7 into aws:main Aug 7, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manodnyab manodnyab manodnyab approved these changes

@tincheng tincheng tincheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhasani23 @tincheng @manodnyab