-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: force reauth when client registration is not found in cache #5102
base: main
Are you sure you want to change the base?
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
can we get some tests? |
} catch (e: ClientRegistrationNotFoundException) { | ||
// invalidate tokens to force a reauth | ||
invalidate() | ||
null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we send the metric here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a metric already being emitted in DiskCache for when loadRegistration fails, and because we are passing in source.REFRESH_TOKEN we already have a metric that tells us when this specifically is happening (vs when it always fails upon first initialization). Assigning null here will also emit this metric here. I'm not sure it needs another metric emitted
Types of changes
Description
Invalidate SSO tokens when client registration file is missing during refresh
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.