Change logic for customization override to not override if user has manually selected a customization #5231
+45
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Fixed
Show fixed
Hide fixed
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Fixed
Show fixed
Hide fixed
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Fixed
Show fixed
Hide fixed
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Fixed
Show fixed
Hide fixed
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Fixed
Show fixed
Hide fixed
spfink
force-pushed
the
finks/default-custom
branch
from
a4619da to
31d7927
Compare
Will-ShaoHua
reviewed
Jan 7, 2025
| if (selectedCustomization != null) { | ||
| return selectedCustomization | ||
| } else { | ||
| val customizationFeature = CodeWhispererFeatureConfigService.getInstance().getCustomizationFeature() |
There was a problem hiding this comment.
nit: can we rename the variable to be val customizationOverride = ...
Will-ShaoHua
reviewed
Jan 7, 2025
| @@ -113,17 +113,37 @@ class CodeWhispererModelConfiguratorTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun `should override customization arn if there is one under AB test`() { | |||
| fun `should not override customization arn if there is one under AB test and manual selection has not been made`() { | |||
There was a problem hiding this comment.
is it supposed to should not override ... and manual selection has been made
Will-ShaoHua
approved these changes
Jan 7, 2025
spfink
force-pushed
the
finks/default-custom
branch
from
31d7927 to
09a5ec6
Compare
manodnyab
approved these changes
Jan 7, 2025
…anually selected a customization
spfink
force-pushed
the
finks/default-custom
branch
from
09a5ec6 to
4accc9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Changes the logic for when a customization will be overridden if the user is part of an AB group that has a customization override. With this change, if the user has manually selected a customization, it will not be overridden by the AB customization.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.