Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): /doc fix prompt to change folder in chat #5249

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

vikshe
Copy link
Contributor

@vikshe vikshe commented Jan 10, 2025

fix(amazonq): /doc agent - fix chat messages and buttons for folder selection

  1. append "Chose a folder to continue" in the chat when user selects folder
  2. when user cancels folder selection dialog display error message and 2 buttons: 'Change folder', 'Cancel'
1 2

Types of changes

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [ X ] My code follows the code style of this project
  • I have added tests to cover my changes
  • [ X ] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vikshe vikshe requested review from a team as code owners January 10, 2025 21:53
@vikshe vikshe marked this pull request as draft January 10, 2025 21:55
@vikshe vikshe force-pushed the bugfix/amazon-q-doc-cancel-or-wrong-folder-sel branch from 2232d2d to 70a1df0 Compare January 10, 2025 22:01
@vikshe vikshe force-pushed the bugfix/amazon-q-doc-cancel-or-wrong-folder-sel branch 2 times, most recently from 1f102c0 to 555ccea Compare January 13, 2025 17:04
@vikshe vikshe marked this pull request as ready for review January 13, 2025 17:59
@vikshe vikshe force-pushed the bugfix/amazon-q-doc-cancel-or-wrong-folder-sel branch 2 times, most recently from 23191ea to c6b3133 Compare January 14, 2025 19:14
@vikshe vikshe closed this Jan 14, 2025
@vikshe vikshe reopened this Jan 14, 2025
@vikshe vikshe force-pushed the bugfix/amazon-q-doc-cancel-or-wrong-folder-sel branch 2 times, most recently from 7bd4f9f to dc143cf Compare January 15, 2025 18:54
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Amazon Q /doc: fix for user prompt to change folder in chat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description" : "Amazon Q /doc: fix for user prompt to change folder in chat"
"description" : "Amazon Q /doc: Prompt user to choose a folder if no folder was selected"

@avi-alpert avi-alpert enabled auto-merge (squash) January 21, 2025 21:33
@vikshe vikshe force-pushed the bugfix/amazon-q-doc-cancel-or-wrong-folder-sel branch from 80a1c2e to 20c164a Compare January 22, 2025 17:32
@rli rli disabled auto-merge January 22, 2025 18:08
@rli rli merged commit b923351 into aws:main Jan 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants