-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(/dev): state transitions #5268
Open
karanA-aws
wants to merge
2
commits into
aws:main
Choose a base branch
from
karanA-aws:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
151 changes: 151 additions & 0 deletions
151
...tware/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/SessionStateChangeTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,151 @@ | ||
// Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package software.aws.toolkits.jetbrains.services.amazonqFeatureDev.session | ||
|
||
import com.intellij.testFramework.RuleChain | ||
import com.intellij.testFramework.replaceService | ||
import io.mockk.coEvery | ||
import io.mockk.every | ||
import io.mockk.just | ||
import io.mockk.mockk | ||
import io.mockk.mockkObject | ||
import io.mockk.mockkStatic | ||
import io.mockk.runs | ||
import io.mockk.spyk | ||
import io.mockk.unmockkAll | ||
import io.mockk.verify | ||
import kotlinx.coroutines.test.runTest | ||
import org.assertj.core.api.Assertions.assertThat | ||
import org.junit.After | ||
import org.junit.Before | ||
import org.junit.Rule | ||
import org.junit.Test | ||
import org.mockito.kotlin.mock | ||
import org.mockito.kotlin.whenever | ||
import software.aws.toolkits.jetbrains.services.amazonq.FeatureDevSessionContext | ||
import software.aws.toolkits.jetbrains.services.amazonq.ZipCreationResult | ||
import software.aws.toolkits.jetbrains.services.amazonq.messages.MessagePublisher | ||
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FeatureDevTestBase | ||
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.clients.FeatureDevClient | ||
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendAnswerPart | ||
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendUpdatePlaceholder | ||
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.FeatureDevService | ||
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.deleteUploadArtifact | ||
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.uploadArtifactToS3 | ||
import software.aws.toolkits.telemetry.AmazonqTelemetry | ||
import java.io.File | ||
|
||
class SessionStateChangeTest : FeatureDevTestBase() { | ||
@Rule | ||
@JvmField | ||
val ruleChain = RuleChain(projectRule, disposableRule) | ||
|
||
private lateinit var session: Session | ||
private lateinit var sessionStateConfig: SessionStateConfig | ||
private lateinit var repoContext: FeatureDevSessionContext | ||
private lateinit var messenger: MessagePublisher | ||
private lateinit var featureDevService: FeatureDevService | ||
private lateinit var featureDevClient: FeatureDevClient | ||
|
||
@Before | ||
override fun setup() { | ||
messenger = mock() | ||
featureDevClient = mock() | ||
featureDevService = mockk() | ||
repoContext = mock() | ||
sessionStateConfig = SessionStateConfig(testConversationId, repoContext, featureDevService) | ||
every { featureDevService.proxyClient } returns featureDevClient | ||
every { featureDevService.project } returns projectRule.project | ||
|
||
projectRule.project.replaceService(FeatureDevService::class.java, featureDevService, disposableRule.disposable) | ||
projectRule.project.replaceService(FeatureDevClient::class.java, featureDevClient, disposableRule.disposable) | ||
projectRule.project.replaceService(SessionStateConfig::class.java, sessionStateConfig, disposableRule.disposable) | ||
session = Session("tabId", projectRule.project) | ||
|
||
var field = Session::class.java.getDeclaredField("featureDevService") | ||
field.isAccessible = true | ||
field.set(session, featureDevService) | ||
|
||
mockkStatic("software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.UploadArtifactKt") | ||
every { uploadArtifactToS3(any(), any(), any(), any(), any()) } just runs | ||
every { deleteUploadArtifact(any()) } just runs | ||
} | ||
|
||
@After | ||
fun clear() { | ||
unmockkAll() | ||
} | ||
|
||
@Test | ||
fun `test complete successful workflow`() = runTest { | ||
// Spy on the session to allow mocking private methods | ||
val sessionSpy = spyk(session, recordPrivateCalls = true) | ||
|
||
// Start from ConversationNotStartedState | ||
assertThat(sessionSpy.sessionState).isInstanceOf(ConversationNotStartedState::class.java) | ||
assertThat(sessionSpy.isAuthenticating).isFalse() | ||
assertThat(sessionSpy.sessionState.phase).isEqualTo(SessionStatePhase.INIT) | ||
|
||
// Mocking FeatureDevClient methods | ||
whenever(featureDevClient.createTaskAssistConversation()).thenReturn(exampleCreateTaskAssistConversationResponse) | ||
whenever(featureDevClient.sendFeatureDevTelemetryEvent(testConversationId)).thenReturn(exampleSendTelemetryEventResponse) | ||
|
||
// Mocking FeatureDevService methods | ||
every { featureDevService.createConversation() } returns testConversationId | ||
every { featureDevService.startTaskAssistCodeGeneration(any(), any(), any(), any(), any()) } returns exampleStartTaskAssistConversationResponse | ||
every { featureDevService.getTaskAssistCodeGeneration(any(), any()) } returns exampleCompleteGetTaskAssistCodeGenerationResponse | ||
coEvery { featureDevService.exportTaskAssistArchiveResult(any()) } returns exampleExportTaskAssistResultArchiveResponse | ||
every { featureDevService.sendFeatureDevEvent(any()) } just runs | ||
|
||
// Mocking AmazonQTelemetry | ||
mockkObject(AmazonqTelemetry) | ||
every { | ||
AmazonqTelemetry.createUpload( | ||
amazonqConversationId = any(), | ||
amazonqRepositorySize = any(), | ||
amazonqUploadIntent = any(), | ||
result = any(), | ||
reason = any(), | ||
reasonDesc = any(), | ||
duration = any(), | ||
credentialStartUrl = any() | ||
) | ||
} just runs | ||
|
||
// Mock the private function | ||
every { sessionSpy["getSessionStateConfig"]() } returns sessionStateConfig | ||
|
||
// Mocking MessagePublisher | ||
mockkStatic(MessagePublisher::sendAnswerPart) | ||
coEvery { messenger.sendAnswerPart(any(), any()) } just runs | ||
coEvery { messenger.sendUpdatePlaceholder(any(), any()) } just runs | ||
|
||
// Preloading session to transition to PrepareCodeGenerationState | ||
sessionSpy.preloader("Test Message", messenger) | ||
assertThat(sessionSpy.sessionState).isInstanceOf(PrepareCodeGenerationState::class.java) | ||
|
||
// Simulating code generation and transitioning back to PrepareCodeGenerationState | ||
val mockFile: File = mock() | ||
val repoZipResult = ZipCreationResult(mockFile, testChecksumSha, testContentLength) | ||
val action = SessionStateAction("test-task", "Test Message") | ||
|
||
whenever(repoContext.getProjectZip()).thenReturn(repoZipResult) | ||
every { featureDevService.createUploadUrl(any(), any(), any(), any()) } returns exampleCreateUploadUrlResponse | ||
|
||
val prepareState = sessionSpy.sessionState as PrepareCodeGenerationState | ||
assertThat(prepareState.currentIteration).isEqualTo(1) | ||
|
||
val actual = prepareState.interact(action) | ||
assertThat(actual.nextState).isInstanceOf(PrepareCodeGenerationState::class.java) | ||
val nextState = actual.nextState as PrepareCodeGenerationState | ||
|
||
verify(exactly = 1) { featureDevService.createConversation() } | ||
assertThat(nextState.phase).isEqualTo(SessionStatePhase.CODEGEN) | ||
assertThat(nextState.codeGenerationRemainingIterationCount).isEqualTo(2) | ||
assertThat(nextState.currentIteration).isEqualTo(1) | ||
assertThat(nextState.codeGenerationTotalIterationCount).isEqualTo(3) | ||
assertThat(actual.interaction.interactionSucceeded).isEqualTo(true) | ||
assertThat(actual.interaction.content).isEqualTo("") | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assert that this sessionState is not the same as the original
PrepareCodeGenerationState
object? Our issue that resulted in the COE was that the sessionState didn't change between the firstPrepareCodeGenerationState
(at the beginning) and this one.