Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow - Publish DockerHub image built on amazonlinux #132

Merged
merged 7 commits into from
Apr 16, 2021
Merged

Workflow - Publish DockerHub image built on amazonlinux #132

merged 7 commits into from
Apr 16, 2021

Conversation

srprash
Copy link
Collaborator

@srprash srprash commented Apr 16, 2021

Issue #, if available: #128, #119

Description of changes:

  • Adding a separate GH workflow to build the daemon image from amazonlinux as base
  • Updating the existing workflow to publish major.x image tag to public ECR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mxiamxia
mxiamxia approved these changes Apr 16, 2021
View reviewed changes
Copy link

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srprash srprash merged commit 118ce43 into aws:master Apr 16, 2021
@srprash srprash deleted the split_release_workflows branch April 16, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiamxia mxiamxia mxiamxia approved these changes

@wangzlei wangzlei wangzlei approved these changes

@willarmiros willarmiros Awaiting requested review from willarmiros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srprash @mxiamxia @wangzlei