add xray sdk language and version in subsegment from Lambda environment #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzlei
changed the title
jj22ee
reviewed
Jun 14, 2024
| @@ -80,6 +80,7 @@ public Subsegment beginSubsegment(AWSXRayRecorder recorder, String name) { | |||
| ? new SubsegmentImpl(recorder, name, parentSegment) | |||
| : Subsegment.noOp(parentSegment, recorder); | |||
| subsegment.setParent(parentSegment); | |||
| subsegment.putAllAws(recorder.getAwsRuntimeContext()); | |||
There was a problem hiding this comment.
If user creates multiple "root subsegments", looks like each will have a copy of this information.
Do we want only one of the subsegments to have this information?
I don't know which is more reasonable: one or all subsegments with this data.
There was a problem hiding this comment.
We are adding this information to all subsegments and not just "root subsegments" (not sure @jj22ee what you mean by this), right?
So it seem redundant to add same information to all the subsegments. Can we possibly add this to the segment created by Lambda runtime?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
X-Ray Segments have X-Ray SDK and version information in field
aws: {xray {}}(refer to code), but in AWS Lambda environment there is only Subsegment can be generated. Customer does not know the xray sdk version by checking trace from xray console.Description of changes:
Appending xray sdk info into the first subsegment generated in each Lambda invocation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.