chore: upgrade lambda and codebuild default runtime from nodejs16.x t…

…o nodejs18.x (#5429) Resolves #5422 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
aws · Oct 31, 2023 · c30e076 · c30e076
1 parent 16da988
commit c30e076
Show file tree

Hide file tree

Showing 47 changed files with 101 additions and 100 deletions.
diff --git a/internal/pkg/addon/package_test.go b/internal/pkg/addon/package_test.go
@@ -80,7 +80,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "TestRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 `,
 			outTemplate: `
 Resources:
@@ -96,7 +96,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "TestRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 `,
 		},
 		"AWS::Glue::Job, non-zipped file": {
@@ -225,7 +225,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "TestRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 `,
 			outTemplate: `
 Resources:
@@ -247,7 +247,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "TestRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 `,
 		},
 		"Fn::Transform nested in a yaml mapping and sequence node": {
@@ -480,7 +480,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "TestRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 `
 		stack := &EnvironmentStack{
 			stack: stack{
@@ -511,7 +511,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "TestRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 `
 		require.NoError(t, err)
 		tmpl, err := stack.Template()

diff --git a/...al/pkg/deploy/cloudformation/stack/testdata/environments/template-with-basic-manifest.yml b/...al/pkg/deploy/cloudformation/stack/testdata/environments/template-with-basic-manifest.yml
@@ -920,7 +920,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   CustomDomainFunction:
     Condition: ManagedAliases
@@ -930,7 +930,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   DNSDelegationFunction:
     Type: AWS::Lambda::Function
@@ -940,7 +940,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   DelegateDNSAction:
     Metadata:
       'aws:copilot:description': 'Delegate DNS for environment subdomain'

diff --git a/...loy/cloudformation/stack/testdata/environments/template-with-cloudfront-observability.yml b/...loy/cloudformation/stack/testdata/environments/template-with-cloudfront-observability.yml
@@ -311,7 +311,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt "UniqueJSONValuesFunctionRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   UniqueAliasesAction:
     Metadata:
       "aws:copilot:description": "An action to get unique custom aliases for services in your environment"

diff --git a/...oy/cloudformation/stack/testdata/environments/template-with-default-access-log-config.yml b/...oy/cloudformation/stack/testdata/environments/template-with-default-access-log-config.yml
@@ -1028,7 +1028,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   CustomDomainFunction:
     Condition: ManagedAliases
@@ -1038,7 +1038,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   DNSDelegationFunction:
     Type: AWS::Lambda::Function
@@ -1048,7 +1048,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   DelegateDNSAction:
     Metadata:
       'aws:copilot:description': 'Delegate DNS for environment subdomain'

diff --git a/...g/deploy/cloudformation/stack/testdata/environments/template-with-defaultvpc-flowlogs.yml b/...g/deploy/cloudformation/stack/testdata/environments/template-with-defaultvpc-flowlogs.yml
@@ -925,7 +925,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   CustomDomainFunction:
     Condition: ManagedAliases
@@ -935,7 +935,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x 
+      Runtime: nodejs18.x 
 
   DNSDelegationFunction:
     Type: AWS::Lambda::Function
@@ -945,7 +945,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   DelegateDNSAction:
     Metadata:

diff --git a/.../deploy/cloudformation/stack/testdata/environments/template-with-importedvpc-flowlogs.yml b/.../deploy/cloudformation/stack/testdata/environments/template-with-importedvpc-flowlogs.yml
@@ -754,7 +754,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   CustomDomainFunction:
     Condition: ManagedAliases
@@ -764,7 +764,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x 
+      Runtime: nodejs18.x 
 
   DNSDelegationFunction:
     Type: AWS::Lambda::Function
@@ -774,7 +774,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt 'CustomResourceRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   DelegateDNSAction:
     Metadata:

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/bb_template.yaml b/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/bb_template.yaml
@@ -125,7 +125,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'
@@ -237,7 +237,7 @@ Resources:
         Type: NO_ARTIFACTS
       Environment:
         Type: LINUX_CONTAINER
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
       Source:

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/cc_template.yaml b/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/cc_template.yaml
@@ -120,7 +120,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'
@@ -211,7 +211,7 @@ Resources:
         Type: NO_ARTIFACTS
       Environment:
         Type: LINUX_CONTAINER
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
       Source:

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/dd_stack_template.yaml b/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/dd_stack_template.yaml
@@ -248,7 +248,7 @@ Resources:
         Type: NO_ARTIFACTS
       Environment:
         Type: LINUX_CONTAINER
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
       Source:

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/gh_template.yaml b/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/gh_template.yaml
@@ -121,7 +121,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'
@@ -234,7 +234,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'
@@ -349,7 +349,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'
@@ -467,7 +467,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'
@@ -585,7 +585,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'
@@ -703,7 +703,7 @@ Resources:
         Type: LINUX_CONTAINER
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         EnvironmentVariables:
           - Name: AWS_ACCOUNT_ID
             Value: !Sub '${AWS::AccountId}'

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/ghv1_template.yml b/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/ghv1_template.yml
@@ -206,7 +206,7 @@ Resources:
         Type: NO_ARTIFACTS
       Environment:
         Type: LINUX_CONTAINER
-        Image: aws/codebuild/amazonlinux2-x86_64-standard:4.0
+        Image: aws/codebuild/amazonlinux2-x86_64-standard:5.0
         ComputeType: BUILD_GENERAL1_SMALL
         PrivilegedMode: true
       Source:

diff --git a/.../pkg/deploy/cloudformation/stack/testdata/workloads/backend/http-autoscaling-template.yml b/.../pkg/deploy/cloudformation/stack/testdata/workloads/backend/http-autoscaling-template.yml
@@ -285,7 +285,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt "DynamicDesiredCountFunctionRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   DynamicDesiredCountFunctionRole:
     Metadata:
       "aws:copilot:description": "An IAM Role for describing number of running tasks in your ECS service"
@@ -464,7 +464,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt "RulePriorityFunctionRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   RulePriorityFunctionRole:
     Metadata:
       "aws:copilot:description": "An IAM Role to describe load balancer rules for assigning a priority"
@@ -568,7 +568,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "EnvControllerRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   EnvControllerRole:
     Metadata:
       "aws:copilot:description": "An IAM role to update your environment stack"

diff --git a/.../pkg/deploy/cloudformation/stack/testdata/workloads/backend/http-full-config-template.yml b/.../pkg/deploy/cloudformation/stack/testdata/workloads/backend/http-full-config-template.yml
@@ -427,7 +427,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt "RulePriorityFunctionRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   RulePriorityFunctionRole:
     Metadata:
       "aws:copilot:description": "An IAM Role to describe load balancer rules for assigning a priority"
@@ -559,7 +559,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "EnvControllerRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   EnvControllerRole:
     Metadata:
       "aws:copilot:description": "An IAM role to update your environment stack"

diff --git a/...al/pkg/deploy/cloudformation/stack/testdata/workloads/backend/http-only-path-template.yml b/...al/pkg/deploy/cloudformation/stack/testdata/workloads/backend/http-only-path-template.yml
@@ -345,7 +345,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt "RulePriorityFunctionRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   RulePriorityFunctionRole:
     Metadata:
       "aws:copilot:description": "An IAM Role to describe load balancer rules for assigning a priority"
@@ -449,7 +449,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "EnvControllerRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   EnvControllerRole:
     Metadata:
       "aws:copilot:description": "An IAM role to update your environment stack"

diff --git a/.../pkg/deploy/cloudformation/stack/testdata/workloads/backend/https-path-alias-template.yml b/.../pkg/deploy/cloudformation/stack/testdata/workloads/backend/https-path-alias-template.yml
@@ -242,7 +242,7 @@ Resources:
       Timeout: 600
       MemorySize: 512
       Role: !GetAtt "RulePriorityFunctionRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   RulePriorityFunctionRole:
     Metadata:
       'aws:copilot:description': "An IAM Role to describe load balancer rules for assigning a priority"
@@ -441,7 +441,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt 'EnvControllerRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   EnvControllerRole:
     Metadata:
       'aws:copilot:description': "An IAM role to update your environment stack"

diff --git a/...y/cloudformation/stack/testdata/workloads/backend/simple-template-without-port-config.yml b/...y/cloudformation/stack/testdata/workloads/backend/simple-template-without-port-config.yml
@@ -341,7 +341,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "EnvControllerRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   EnvControllerRole:
     Metadata:
       "aws:copilot:description": "An IAM role to update your environment stack"

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/workloads/backend/simple-template.yml b/internal/pkg/deploy/cloudformation/stack/testdata/workloads/backend/simple-template.yml
@@ -351,7 +351,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt "EnvControllerRole.Arn"
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
   EnvControllerRole:
     Metadata:
       "aws:copilot:description": "An IAM role to update your environment stack"

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/workloads/job-test.stack.yml b/internal/pkg/deploy/cloudformation/stack/testdata/workloads/job-test.stack.yml
@@ -70,7 +70,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt 'EnvControllerRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   EnvControllerRole:
     Metadata:

diff --git a/internal/pkg/deploy/cloudformation/stack/testdata/workloads/rdws-test.stack.yml b/internal/pkg/deploy/cloudformation/stack/testdata/workloads/rdws-test.stack.yml
@@ -288,7 +288,7 @@ Resources:
       Timeout: 900
       MemorySize: 512
       Role: !GetAtt 'EnvControllerRole.Arn'
-      Runtime: nodejs16.x
+      Runtime: nodejs18.x
 
   EnvControllerRole:
     Metadata: