Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Kubernetes version is always parsed as string #9185

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

abhay-krishna
Copy link
Member

@abhay-krishna abhay-krishna commented Jan 17, 2025

Ensure Kubernetes version in cluster config is always parsed as string regardless of whether it is quoted or not. Ref: #9184.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (b9cdab7) to head (601c8e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cluster/config_manager.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9185   +/-   ##
=======================================
  Coverage   72.37%   72.37%           
=======================================
  Files         585      585           
  Lines       45713    45708    -5     
=======================================
- Hits        33085    33082    -3     
+ Misses      10890    10888    -2     
  Partials     1738     1738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna abhay-krishna force-pushed the kubeversion-string branch 2 times, most recently from 318f1da to f3ebb5e Compare January 17, 2025 08:57
@abhay-krishna
Copy link
Member Author

/retest eks-anywhere-release-tooling-test-presubmit

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test eks-anywhere-cli-attribution-presubmit
  • /test eks-anywhere-cluster-controller-tooling-presubmit
  • /test eks-anywhere-docs-presubmit
  • /test eks-anywhere-e2e-presubmit
  • /test eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit
  • /test eks-anywhere-generate-files-presubmit
  • /test eks-anywhere-presubmit
  • /test eks-anywhere-release-tooling-presubmit
  • /test eks-anywhere-release-tooling-test-presubmit

Use /test all to run the following jobs that were automatically triggered:

  • eks-anywhere-cli-attribution-presubmit
  • eks-anywhere-e2e-presubmit
  • eks-anywhere-generate-files-presubmit
  • eks-anywhere-presubmit
  • eks-anywhere-release-tooling-presubmit
  • eks-anywhere-release-tooling-test-presubmit

In response to this:

/retest eks-anywhere-release-tooling-test-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/test eks-anywhere-release-tooling-test-presubmit

pkg/utils/yaml/yaml_test.go Outdated Show resolved Hide resolved
pkg/yamlutil/parser.go Outdated Show resolved Hide resolved
pkg/constants/constants.go Outdated Show resolved Hide resolved
pkg/api/v1alpha1/cluster.go Outdated Show resolved Hide resolved
@vivek-koppuru
Copy link
Member

/cherrypick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@vivek-koppuru: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vivek-koppuru
Copy link
Member

/cherrypick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@vivek-koppuru: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 1c76611 into aws:main Jan 20, 2025
14 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@vivek-koppuru: new pull request created: #9187

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@vivek-koppuru: new pull request created: #9188

In response to this:

/cherrypick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants