Add CI to run unit tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoranleo
force-pushed
the
haoranleo-patch-1
branch
from
5a4762c to
ec14a0a
Compare
haoranleo
force-pushed
the
haoranleo-patch-1
branch
from
ec14a0a to
3437154
Compare
shizuchanw
reviewed
Dec 19, 2024
There was a problem hiding this comment.
https://github.com/aws/eks-pod-identity-agent/pull/37/files#diff-245392b692a50c38ecab4381b118862db514035c10983f3bd4f4b7f1f4be4692R14
don't think we have a .go-version?
Good catch, seems it automatically picked 1.23.4, but explicitly added |
shizuchanw
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add CI to run unit tests on PRs, the CI also verifies if the generated helm template matches with the expected one
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.