-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 233 #311
Issue 233 #311
Conversation
<th style="text-align: center">Data</th> | ||
<th style="text-align: center" title="The transaction or op number within a transaction">Tx/Op#</th> | ||
<th style="text-align: center" title="The type of operation such as ADD or REMOVE">Operation</th> | ||
<th style="text-align: center" title="Indicates if this is the final Op of a transaction. This feature requires a Neptune engine version of 1.1.1.0 or higher.">LastOp</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Optional]
<th style="text-align: center" title="Indicates if this is the final Op of a transaction. This feature requires a Neptune engine version of 1.1.1.0 or higher.">LastOp</th> | |
<th style="text-align: center" title="Indicates if this is the final Op of a transaction. This feature requires Neptune engine version 1.1.1.0 or higher.">LastOp</th> |
|
||
html += '<tr style="border: 1px solid black; background-color: white;">' | ||
html += '''<td title="The operation number within this transaction" style="border: 1px solid black; vertical-align: top;">{}</td> | ||
<td title="The operation performed"style="border: 1px solid black; vertical-align: top;text-align: center;">{}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Minor]
<td title="The operation performed"style="border: 1px solid black; vertical-align: top;text-align: center;">{}</td> | |
<td title="The operation performed" style="border: 1px solid black; vertical-align: top;text-align: center;">{}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! These changes are going to be very useful for Neptune users looking to take advantage of new streams features in the latest engine versions.
Issue #, if available: #233
Description of changes:
Adds support to
%stream_viewer
forisLastOp
and the commit timestamp, if available. Also adds more help (hover) text to the viewer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.