Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 233 #311

Merged
merged 9 commits into from
Jun 21, 2022
Merged

Issue 233 #311

merged 9 commits into from
Jun 21, 2022

Conversation

krlawrence
Copy link
Contributor

@krlawrence krlawrence commented Jun 21, 2022

Issue #, if available: #233

Description of changes:

Adds support to %stream_viewer for isLastOp and the commit timestamp, if available. Also adds more help (hover) text to the viewer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krlawrence krlawrence requested a review from michaelnchin June 21, 2022 14:31
<th style="text-align: center">Data</th>
<th style="text-align: center" title="The transaction or op number within a transaction">Tx/Op#</th>
<th style="text-align: center" title="The type of operation such as ADD or REMOVE">Operation</th>
<th style="text-align: center" title="Indicates if this is the final Op of a transaction. This feature requires a Neptune engine version of 1.1.1.0 or higher.">LastOp</th>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional]

Suggested change
<th style="text-align: center" title="Indicates if this is the final Op of a transaction. This feature requires a Neptune engine version of 1.1.1.0 or higher.">LastOp</th>
<th style="text-align: center" title="Indicates if this is the final Op of a transaction. This feature requires Neptune engine version 1.1.1.0 or higher.">LastOp</th>


html += '<tr style="border: 1px solid black; background-color: white;">'
html += '''<td title="The operation number within this transaction" style="border: 1px solid black; vertical-align: top;">{}</td>
<td title="The operation performed"style="border: 1px solid black; vertical-align: top;text-align: center;">{}</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor]

Suggested change
<td title="The operation performed"style="border: 1px solid black; vertical-align: top;text-align: center;">{}</td>
<td title="The operation performed" style="border: 1px solid black; vertical-align: top;text-align: center;">{}</td>

gopuneet
gopuneet previously approved these changes Jun 21, 2022
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! These changes are going to be very useful for Neptune users looking to take advantage of new streams features in the latest engine versions.

@michaelnchin michaelnchin merged commit 467414c into main Jun 21, 2022
@michaelnchin michaelnchin deleted the ISSUE-233 branch June 21, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants