fix: use pypa/build to create Python sdists and wheels #4850
Conversation
Using wheel directly generates whl files that aren't compliant with https://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode . Specifically, periods in the distribution name aren't converted to underscores like setuptools would do. When uploading such a wheel to PyPi, you get an email notification from them complaining about it and warning that soon it would be denied. However, running setup.py directly to do create a `bdist_wheel` now produces a deprecation warning. The upstream advice is to use the `pypa/build` module to wrap setuptools, so that's what I implemented here. The Python target no longer depends on `wheel` directly, so I removed it.
ataraxia937
force-pushed
the
python_build
branch
from
632d42b to
189f76e
Compare
|
I've updated the snapshots for this change. I don't know how I forgot to do that when I opened the PR. |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio requeue |
|
@Mergifyio update |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
Merging (with squash)... |
Using wheel directly generates
whlfiles that aren't compliant withhttps://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode
. Specifically, periods in the distribution name aren't converted to
underscores like setuptools would do. When uploading such a wheel to
PyPi, you get an email notification from them complaining about it and
warning that soon it would be denied.
However, running setup.py directly to do create a
bdist_wheelnowproduces a deprecation warning. The upstream advice is to use the
pypa/buildmodule to wrap setuptools, so that's what I implementedhere. The Python target no longer depends on
wheeldirectly, so Iremoved it.