Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace memcmp to s2n_constant_time_equals #4709

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Replace memcmp to s2n_constant_time_equals #4709

merged 11 commits into from
Sep 5, 2024

Commits on Aug 15, 2024

  1. refactor: replacing memcmp by s2n_constant_time_equals

    Boquan Fang committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    cdb3cbe View commit details
    Browse the repository at this point in the history

  2. refactor: modify conditional statments for s2n_constant_time_equals

    Boquan Fang committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    571f2ba View commit details
    Browse the repository at this point in the history

  3. refactor: respond to PR comments and attempt to fix CI problem

    Boquan Fang committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ac6f580 View commit details
    Browse the repository at this point in the history

  4. Address PR and CI concerns 

    * Let s2n_stuffer_read_expected_str use memcmp to avoid CBMC problem.
    Boquan Fang committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    359e689 View commit details
    Browse the repository at this point in the history

  5. Address PR and CI concerns: 

    * Adding one more known memcmp location to grep_simple_mistakes.sh.
    Boquan Fang committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c676feb View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Address CR comments: 

    * Replace S2N_ERROR_IF to POSIX_ENSURE.
    Boquan Fang committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e7049af View commit details
    Browse the repository at this point in the history

  2. Address CR concern: 

    * Reorder the .sh order to fit the directory order.
    Boquan Fang committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    12295ca View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Remove cases with possibility of pathological inputs 

    Remove the usage of s2n_constant_time_equals from any functions where
it is possible to compare relatively large amounts of data (~ > 1 kB)
even if that scenario is unlikely.
    Boquan Fang committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0feaa68 View commit details
    Browse the repository at this point in the history

  2. fix: fix grep_simple_mistakes.sh to include additional memcmp calls

    Boquan Fang committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    19f1016 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge branch 'main' into replace-memcmp

    @boquan-fang
    boquan-fang authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c541742 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'main' into replace-memcmp

    @boquan-fang
    boquan-fang authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c0d426c View commit details
    Browse the repository at this point in the history