test(s2n-tls-hyper): matching on s2n-tls error #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
approved these changes
Nov 19, 2024
lrstewart
approved these changes
Nov 19, 2024
lrstewart
reviewed
Nov 19, 2024
| async fn serve_echo<B>( | ||
| pub async fn serve_echo<B>( |
There was a problem hiding this comment.
Nit: should this be pub or pub(crate)?
There was a problem hiding this comment.
I do think it should be pub, because pub(crate) feels a bit redundant. This is in a submodule of the test folder, so the entire module is already private and not available to external consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Prompted by discussion in #4884
Description of changes:
The PR adds a "sanity check" test covering customer interactions with hyper and s2n-tls errors. This confirms that hyper isn't doing anything tricky (like converting TLS errors to HTTP errors) and that the original s2n-tls error descriptions can still be inspected.
Testing:
No functional changes, this just tests existing behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.