Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): Installs Nix in AL2023 Buildspec #4934

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maddeleine
Copy link
Contributor

Release Summary:

N/A

Resolved issues:

N/A

Description of changes:

Installs Nix in our buildspec for KTLS. My understanding of this issue is that build environments "sometimes" get reused, and "sometimes" they do not. So if we want to ensure Nix exists, we need to install it ourselves.

Call-outs:

N/A

Testing:

ktls tests pass: https://tiny.amazon.com/qzqz64ll/IsenLink

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Comment on lines +14 to +15
# Install nix
- sh <(curl -L https://nixos.org/nix/install) --no-daemon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary as opposed to just vanilla curl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curl command inside the parentheses gets the installation script. However, in order to actually run the script you have to pipe it to sh. I'm basically just following the nix install guide https://nix.dev/manual/nix/2.18/installation/installation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably also work:
curl -L https://nixos.org/nix/install | sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants