Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bench): remove historical benchmarks #4940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmayclin
Copy link
Contributor

Resolved issues:

Related to some discussion in #4847

Description of changes:

In the last 18 months

  1. historical benchmarks haven't been used
  2. memory benchmarking hasn't been used (and breaks when I try to build it)
  3. feature gating hasn't been used

Remove the unused functionality to simplify things. If someone really wanted to use this they could always restore it from git history.

Testing:

Ensured that the bench command still ran.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmayclin jmayclin marked this pull request as ready for review November 27, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant