-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integv2): fixes to allow test_record_padding to partially run #5099
Open
johubertj
wants to merge
5
commits into
aws:main
Choose a base branch
from
johubertj:feature-recordPaddingTestFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Feb 7, 2025
917d78b
to
910665b
Compare
jmayclin
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that it's passing, let's go ahead and addtest_record_padding
back to the CI:
s2n-tls/codebuild/spec/buildspec_ubuntu_integrationv2.yml
Lines 38 to 45 in 8201205
INTEGV2_TEST: | |
- "test_client_authentication test_dynamic_record_sizes test_sslyze test_sslv2_client_hello" | |
- "test_happy_path" | |
- "test_cross_compatibility" | |
- "test_early_data test_well_known_endpoints test_hello_retry_requests test_sni_match test_pq_handshake test_fragmentation test_key_update" | |
- "test_session_resumption test_renegotiate_apache test_buffered_send" | |
- "test_npn test_signature_algorithms" | |
- "test_version_negotiation test_external_psk test_ocsp test_renegotiate test_serialization" |
jmayclin
approved these changes
Feb 19, 2025
Co-authored-by: James Mayclin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Problem
The way the I/O loop previously operated is shown w/ the below psuedo code.
For a test to exit successfully, we must detect the close marker from stdout. Previously stderr was always empty so
data_str
was always populated from stdout.In PR #3945, s2n-tls behavior was changed so that improper shutdowns cause errors. This affected
test_record_padding.py
because stderr was no longer empty. While the close marker was still read from stdout intodata_str
, the second iteration of the I/O loop overwrote the close marker with the message from stderr.This change solves this problem by checking for the close marker every iteration.
Related Issue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.