refactor: remove unused evp support for md5+sha1 #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
openssl3fips_evp_1
branch
5 times, most recently
from
72b2631 to
99196b9
Compare
lrstewart
force-pushed
the
openssl3fips_evp_1
branch
from
99196b9 to
9bcb175
Compare
lrstewart
commented
Feb 11, 2025
Comment on lines
+20
to
+21
|
|
||
| bool s2n_evp_signing_supported() |
There was a problem hiding this comment.
This follows the model set by s2n_is_in_fips_mode and s2n_libcrypto_is_awslc
goatgoose
approved these changes
Feb 12, 2025
jmayclin
approved these changes
Feb 12, 2025
lrstewart
added a commit
to lrstewart/s2n
that referenced
this pull request
Feb 14, 2025
This reverts commit f3ae011.
lrstewart
added a commit
to lrstewart/s2n
that referenced
this pull request
Feb 14, 2025
This reverts commit f3ae011.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #5105
Description of changes:
Read #5105 -- this change won't make sense in context without it. After this change:
This PR tackles Task 1 from the related issue and cleans up the unused openssl-1.0.2-fips signing logic. This logic was used only for openssl-1.0.2-fips (in fips mode) because that was the only libcrypto:
There should be NO practical behavior change from this change.
Callouts
But why are we removing the EVP version instead of the legacy version?
Because MD5 is legacy. Even in our perfect end state where almost everything is using EVP, openssl-3.0-fips will still need to use the legacy methods for MD5. Might as well let openssl-1.0.2 use the same legacy code, rather than complicating the EVP code to support openssl-1.0.2's strange MD5+SHA1 needs.
Testing:
Unit tests.
Updated the CBMC tests to test with both the EVP and legacy setups.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.