Skip to content

ci: enable daily CI run for rust bindings #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented May 23, 2025

Release Summary:

Resolved issues:

Similar to aws/s2n-quic#2624.

Description of changes:

Similar to what we have done in S2N-QUIC, we want the S2N-TLS' rust bindings CI to run daily at 8 PM every day. The run should detect if there are any failures with other jobs. If every jobs succeed, then it would report the value of zero to Cloud Watch metrics, otherwise it would report one. When the Cloud Watch metrics detect one is report, it should fire a Cloud Watch Alarm and cut tickets to our ticketing queue.

The benefits of this daily run is that we can preemptively detect any MSRV bumps of our dependencies. If that should fail the CI, we will receive a notification of that. Engineers shouldn't be surprised by MSRV bump that breaks our CI.

Call-outs:

This code can not be tested without merging. Once this is merged, we should monitor several things daily:

  1. We should verify the result of the daily run.
  2. We should verify that the correct code (zero for success, one for failure) is sent to Cloud Watch.

After about 5 days without any problems, we can set up an Cloud Watch Alarm to actually cutting tickets.

Testing:

As mentioned in the Call-outs section, this code can not be tested without merging. However, we can use this PR to verify that the last job will be called once all of the previous jobs are finished.

The CI test can be found here: https://github.com/aws/s2n-tls/actions/runs/15199891804?pr=5328.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label May 23, 2025
@boquan-fang boquan-fang marked this pull request as ready for review May 23, 2025 01:26
@boquan-fang boquan-fang requested review from dougch and jmayclin May 23, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant