Add Release Workflow #59
Conversation
Add a workflow to build and publish a release with tarball of Code Editor. **Testing** An example of a successful run of a workflow extremely similar to this: https://github.com/aws-donocl/sagemaker-code-editor/actions/runs/10564424011 **Notes** This demonstrates updating the meta.yaml file in sagemaker-code-editor-feedstock. However, the feedstock repository does not get actually updated by this workflow, due to time constraints. This was decided together with @aws-zuoyuan.
| ref: 'dev' | ||
| - name: Create a new dev branch | ||
| run: | | ||
| git checkout -b ${{ env.branch-name }} |
There was a problem hiding this comment.
where does env.branch-name come from? what if a branchw ith the same name already exists?
There was a problem hiding this comment.
This comes from lines 16-17. The branch is called 1automated-dev-update`. I believe if there is already a branch with this name, it will still checkout that branch.
| SHA256=${{ needs.release.outputs.sha256_hash }} | ||
| sed -i "s|sha256: [0-9a-f]*|sha256: $SHA256|" recipe/meta.yaml | ||
| - name: Run diff | ||
| run: git diff |
There was a problem hiding this comment.
Is the updated meta.yaml not pushed to the new branch?
There was a problem hiding this comment.
Correct. From the merge request description:
This demonstrates updating the meta.yaml file in sagemaker-code-editor-feedstock. However, the feedstock repository does not get actually updated by this workflow, due to time constraints. This was decided together with @aws-zuoyuan.
There was a problem hiding this comment.
We can discuss this during standup if you feel its necessary
There was a problem hiding this comment.
Okay, that's fine. If you don't plan to implement this can you create a backlog issue for this and link it here
| # Triggers the workflow on updates to the "main" branch which include a version tag | ||
| push: | ||
| tags: | ||
| - '**' # Push events to every tag including hierarchical tags like v1.0/beta |
There was a problem hiding this comment.
should we only check tags with prefix v*?
Add a workflow to build and publish a release with tarball of Code Editor.
This workflow is triggered whenever a tag is pushed that begins with
v(ex.v10.0.1orv10.0.1-dev).Manual approval is required for the tarball to be created and published as a release.
Testing
An example of a successful run of a workflow extremely similar to this: https://github.com/aws-donocl/sagemaker-code-editor/actions/runs/10564424011
Notes
This demonstrates updating the meta.yaml file in sagemaker-code-editor-feedstock. However, the feedstock repository does not get actually updated by this workflow, due to time constraints. This was decided together with @aws-zuoyuan.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.