feat: Marketplace model support in HubService #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstfu
changed the title
AWS-pratab
approved these changes
Oct 30, 2024
bencrabtree
approved these changes
Oct 30, 2024
pintaoz-aws
previously approved these changes
Oct 30, 2024
…chrstfu/sagemaker-python-sdk into marketplace-hub-service-support
JGuinegagne
reviewed
Oct 31, 2024
| @@ -451,12 +451,14 @@ def from_json(self, json_obj: str) -> None: | |||
| class HubModelDocument(HubDataHolderType): | |||
| """Data class for model type HubContentDocument from session.describe_hub_content().""" | |||
|
|
|||
| SCHEMA_VERSION = "2.2.0" | |||
| SCHEMA_VERSION = "2.3.0" | |||
There was a problem hiding this comment.
sanity-check: will the pySDK still understand previous schema?
| # remove any hyphen from the string for accurate conversion. | ||
| snake_case_string = snake_case_string.replace("-", "") | ||
| return re.sub("([a-z0-9])([A-Z])", r"\1_\2", snake_case_string).lower() | ||
| """Converts PascalCase to snake_case_string using a regex. |
There was a problem hiding this comment.
Inconsistent regex and method name.
Careful with renaming the method though, it would be backward incompatible.
There was a problem hiding this comment.
True, let me rewrite that docstring. This regex can handle camelCase as well as PascalCase
| @@ -881,6 +890,37 @@ def validate_model_id_and_get_type( | |||
| return None | |||
|
|
|||
|
|
|||
| def _validate_hub_service_model_id_and_get_type( | |||
| model_id: Optional[str], | |||
There was a problem hiding this comment.
just curious, what happens if model_id is None?
There was a problem hiding this comment.
Ah that should be just str. Thanks, good catch!
| boto_session = boto3.Session(region_name="us-west-2") | ||
| sagemaker = boto3.client( | ||
| service_name="sagemaker", | ||
| endpoint_url="https://sagemaker.gamma.us-west-2.ml-platform.aws.a2z.com", |
There was a problem hiding this comment.
Did you merge this to main? Block the release if that's the case.
Btw this code should never have been pushed to the public repo...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding Marketplace model support in HubService
Testing done:
Testing was completed locally with example models via a BugBash. Unit tests are added to check functionality.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.