Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Enabled update_endpoint through model_builder #5085

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

rsareddy0329
Copy link
Contributor

@rsareddy0329 rsareddy0329 commented Mar 12, 2025

Issue #, if available:
github issue: #2545
Description of changes:

  • This code change enables update_endpoint through model_builder i.e., add update_endpoint to support session class to update endpoint instead of creating new one.
    Users will be able to use an optional flag(update_endpoint) in .deploy method accordingly based on preference to update existing endpoint or create a new one

Note:

  • The change of Update endpoint is supported for single model endpoints, which updates existing endpoint with user provided model configuration instead of creating a new one.
  • In case of multimodel, With the current code flow if endpoint already exists, a new model is added to the existing endpoint.

Testing done:

  • Added relevant unit tests and verified this change of addition of update_endpoint flag.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate) - Updated API doc strings in the updated files

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsareddy0329 rsareddy0329 marked this pull request as ready for review March 12, 2025 18:08
@rsareddy0329 rsareddy0329 requested a review from a team as a code owner March 12, 2025 18:08
@rsareddy0329 rsareddy0329 requested a review from bhadrip March 12, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants