Support custom log4j.properties for torchserve #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@icywang86rui Here's another PR for you to take a look at. Thank you! |
|
@schenqian would you mind taking a look at this PR? Thanks! |
|
+1, this would be very useful |
|
This looks very useful! |
maaquib
reviewed
Jul 25, 2023
Co-authored-by: Aaqib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
By default, the logging level for
torchserveisINFO, which can create a ton of logs.#83
Description of changes:
There is a hacky workaround where you can fork this repo, change the
log4j.properties, and install that fork inrequirements.txt, but the changes in this PR support a more elegant solution.The code simply checks the code directory for
log4j.properties(in exactly the same way it looks forrequirements.txt). If it finds that file, it uses it for the logging configuration passed totorchserve. If it doesn't, it uses the default.