Remove resolved TODOs.

aws4embeddedlinux · Nov 20, 2023 · 2749733 · 2749733
1 parent 11e4467
commit 2749733
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 14 deletions.
diff --git a/lib/build-image-pipeline.ts b/lib/build-image-pipeline.ts
@@ -48,7 +48,7 @@ export class BuildImagePipelineStack extends cdk.Stack {
     const sourceAction = new codepipeline_actions.S3SourceAction({
       actionName: 'Build-Image-Source',
       bucket: props.dataBucket,
-      bucketKey: 'data.zip', // TODO(glimsdal): Parameterize.
+      bucketKey: 'data.zip',
       output: sourceOutput,
     });
 

diff --git a/lib/demo-pipeline.ts b/lib/demo-pipeline.ts
@@ -340,7 +340,6 @@ def handler(event, context):
   ): string {
     const fs = new efs.FileSystem(this, `DemoPipeline${name}Filesystem`, {
       vpc,
-      // TODO(nateglims): Reconsider this when development is slowing down.
       removalPolicy: cdk.RemovalPolicy.DESTROY,
     });
     fs.connections.allowFrom(securityGroup, Port.tcp(2049));

diff --git a/test/build-image-repo.test.ts b/test/build-image-repo.test.ts
@@ -7,17 +7,6 @@ describe('Build Image Repository', () => {
     env: { account: '111111111111', region: 'eu-central-1' },
   };
 
-  test('ECR Repo has EmptyOnDelete', () => {
-    const app = new cdk.App();
-    const stack = new BuildImageRepoStack(app, 'MyTestStack', props);
-    const template = Template.fromStack(stack);
-    template.resourceCountIs('AWS::ECR::Repository', 1);
-    // TODO: Investigate why we cannot set EmptyOnDelete in CDK.
-    // template.hasResourceProperties("AWS::ECR::Repository", {
-    //   EmptyOnDelete: true,
-    // });
-  });
-
   test('Snapshot', () => {
     const app = new cdk.App();
     const stack = new BuildImageRepoStack(app, 'MyTestStack', props);

diff --git a/test/demo-pipeline-nag.test.ts b/test/demo-pipeline-nag.test.ts
@@ -35,7 +35,7 @@ describe('Demo pipeline cdk-nag AwsSolutions Pack', () => {
       },
       {
         id: 'AwsSolutions-CB3',
-        reason: 'TODO: Verify CodeBuild Privilege mode is required here.',
+        reason: 'CodeBuild Privilege mode is required for this pipeline.',
       },
 
       {