add parameters to embedded-linux-pipeline: accessLoggingBucket, artif… #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-roos
force-pushed
the
bucket-reduction
branch
from
e558a8e
to
386549e
Compare
thomas-roos
force-pushed
the
bucket-reduction
branch
from
386549e
to
7b5fe5b
Compare
alinadima
reviewed
Jan 24, 2024
thomas-roos
force-pushed
the
bucket-reduction
branch
2 times, most recently
from
0e8be82
to
42d9bf1
Compare
nateglims
reviewed
Jan 25, 2024
| let artifactAction: codepipeline_actions.S3DeployAction; | ||
|
|
||
| if (props.subDirectoryName){ | ||
| artifactAction = new codepipeline_actions.S3DeployAction({ |
There was a problem hiding this comment.
Only some things get into the final bucket with this action. There is also some things in the build spec files.
There was a problem hiding this comment.
What do you mean by "some things" ?
By setting the subDirectoryName all uploaded artifacts go into a sub dir...
…actBucket, outputBucket
thomas-roos
force-pushed
the
bucket-reduction
branch
from
42d9bf1
to
5ea4daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…actBucket, outputBucket
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.