Skip to content

Commit

Permalink
Merge pull request #56 from alinadima/cdk-pipeline
Browse files Browse the repository at this point in the history
Fix the network stack id
  • Loading branch information
nateglims committed Aug 16, 2023
2 parents c570fa1 + 9c5795e commit 8770abe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion demos-pipeline/example/bin/poky-pipeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ new BuildImagePipelineStack(app, "BuildImagePipeline", {
/**
* Set up networking to allow us to securely attach EFS to our CodeBuild instances.
*/
const vpc = new PipelineNetworkStack(app, "PipelineNetwork", {
const vpc = new PipelineNetworkStack(app, {

Check failure on line 53 in demos-pipeline/example/bin/poky-pipeline.ts

View workflow job for this annotation

GitHub Actions / Run-CDK-Tests (16.x, demos-pipeline/example)

Delete `·`

Check failure on line 53 in demos-pipeline/example/bin/poky-pipeline.ts

View workflow job for this annotation

GitHub Actions / Run-CDK-Tests (18.x, demos-pipeline/example)

Delete `·`

Check failure on line 53 in demos-pipeline/example/bin/poky-pipeline.ts

View workflow job for this annotation

GitHub Actions / Run-CDK-Tests (20.x, demos-pipeline/example)

Delete `·`
...defaultProps,
});

Expand Down
4 changes: 2 additions & 2 deletions demos-pipeline/lib/lib/network.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ export class PipelineNetworkStack extends cdk.Stack {
/** The VPC for the pipeline to reside in. */
public readonly vpc: ec2.IVpc;

constructor(scope: Construct, id: string, props?: cdk.StackProps) {
super(scope, id, props);
constructor(scope: Construct, props?: cdk.StackProps) {
super(scope, 'PipelineNetwork', props);

Check failure on line 13 in demos-pipeline/lib/lib/network.ts

View workflow job for this annotation

GitHub Actions / Run-CDK-Tests (16.x, demos-pipeline/lib)

Replace `'PipelineNetwork'` with `"PipelineNetwork"`

Check failure on line 13 in demos-pipeline/lib/lib/network.ts

View workflow job for this annotation

GitHub Actions / Run-CDK-Tests (18.x, demos-pipeline/lib)

Replace `'PipelineNetwork'` with `"PipelineNetwork"`

// We will create a VPC with 3 Private and Public subnets for AWS
// Resources that have network interfaces (e.g. Connecting and EFS
Expand Down

0 comments on commit 8770abe

Please sign in to comment.