Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Laren-AWS <[email protected]>
  • Loading branch information
rlhagerm and Laren-AWS authored Oct 13, 2023
1 parent 37304bb commit 096cebf
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ public class ExtractTextFunction

/// <summary>
/// Default constructor. This constructor is used by Lambda to construct the instance. When invoked in a Lambda environment
/// the AWS credentials will come from the IAM role associated with the function and the AWS region will be set to the
/// region the Lambda function is executed in.
/// the AWS credentials will come from the IAM role associated with the function and the AWS Region will be set to the
/// Region the Lambda function is executed in.
/// </summary>
public ExtractTextFunction()
{
Expand All @@ -32,7 +32,7 @@ public ExtractTextFunction()
}

/// <summary>
/// Constructs an instance with an Amazon Textract client. This can be used for testing the outside of the Lambda environment.
/// Constructs an instance with an Amazon Textract client. This can be used for testing outside of the Lambda environment.
/// </summary>
/// <param name="textractClient">Preconfigured Textract client.</param>
public ExtractTextFunction(IAmazonTextract textractClient)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace FsaServicesTest;
public class ExtractionServiceTests
{
/// <summary>
/// Verify that extracting words from an object should return a string.
/// Verify that extracting words from an object returns a string.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand Down Expand Up @@ -48,7 +48,7 @@ public async Task SynthesizeSpeech_ShouldReturnObjectKey()
}

/// <summary>
/// Verify that no words in the extraction should return an empty string.
/// Verify that no words in the extraction returns an empty string.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace FsaServicesTest;
public class SentimentServiceTests
{
/// <summary>
/// Verify that translating to English should return a string.
/// Verify that translating to English returns a string.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand Down Expand Up @@ -51,7 +51,7 @@ public async Task DetectSentiment_ShouldReturnSentimentDetails()
}

/// <summary>
/// Verify that an empty string should throw an Invalid Operation Exception.
/// Verify that an empty string throws an Invalid Operation Exception.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace FsaServicesTest;
public class SynthesizeServiceTests
{
/// <summary>
/// Verify that translating to English should return a string.
/// Verify that translating to English returns a string.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand Down Expand Up @@ -50,7 +50,7 @@ public async Task SynthesizeSpeech_ShouldReturnObjectKey()
}

/// <summary>
/// Verify that an empty string should throw an Invalid Operation Exception.
/// Verify that an empty string throws an Invalid Operation Exception.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace FsaServicesTest;
public class TranslationServiceTests
{
/// <summary>
/// Verify that translating to English should return a string.
/// Verify that translating to English returns a string.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand All @@ -38,7 +38,7 @@ public async Task TranslateToEnglish_ShouldReturnString()
}

/// <summary>
/// Verify that an empty string should throw an Invalid Operation Exception.
/// Verify that an empty string throws an Invalid Operation Exception.
/// </summary>
[Fact]
[Trait("Category", "Unit")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public SynthesizeAudioFunction()
}

/// <summary>
/// Constructs an instance with an Amazon Textract client. This can be used for testing the outside of the Lambda environment.
/// Constructs an instance with an Amazon Textract client. This can be used for testing outside of the Lambda environment.
/// </summary>
/// <param name="s3Client"></param>
public SynthesizeAudioFunction(IAmazonPolly pollyClient, IAmazonS3 s3Client)
Expand Down

0 comments on commit 096cebf

Please sign in to comment.