Rust: use std::io::Write::write_all to not have potential data loss.

Closes #5530
awsdocs · Nov 2, 2023 · 2f98b73 · 2f98b73
1 parent 6fffcc8
commit 2f98b73
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/rust_dev_preview/cross_service/photo_asset_management/src/uploader.rs b/rust_dev_preview/cross_service/photo_asset_management/src/uploader.rs
@@ -57,7 +57,7 @@ impl<'a> ZipUpload<'a> {
 
         let mut byte_count = 0_usize;
         while let Some(bytes) = object.body.try_next().await? {
-            let bytes = self.zip.write(&bytes)?;
+            let bytes = self.zip.write_all(&bytes)?;
             byte_count += bytes;
             tracing::trace!("Intermediate read of {bytes} (total {byte_count})");
         }

diff --git a/rust_dev_preview/examples/s3/src/bin/get-object.rs b/rust_dev_preview/examples/s3/src/bin/get-object.rs
@@ -32,9 +32,10 @@ async fn get_object(client: Client, opt: Opt) -> Result<usize, anyhow::Error> {
 
     let mut byte_count = 0_usize;
     while let Some(bytes) = object.body.try_next().await? {
-        let bytes = file.write(&bytes)?;
-        byte_count += bytes;
-        trace!("Intermediate write of {bytes}");
+        let bytes_len = bytes.len();
+        file.write_all(&bytes)?;
+        trace!("Intermediate write of {bytes_len}");
+        byte_count += bytes_len;
     }
 
     Ok(byte_count)